[LLVM/ABI] Don't pass null pointer to byVal attribute #44555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
backport 1.8
|
Needs a rebase (or just click the "Update branch" button) to fix Buildkite. |
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
47 tasks
KristofferC
pushed a commit
that referenced
this pull request
Mar 12, 2022
(cherry picked from commit f5d1557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #43417 I adjusted the ABI code to pass the LLVM type to the
ByValattribute.IIRC the LLVM type should come from the outside (and does for every other case),
but I seem to have left some old cold in that tried to get the LLVM type for the
argument again, but could return Null for VecElement.
In #44365 @pchintalapudi noticed that the LLVM verifier would fail, since in the
ccalltests we try to pass a VecElement wrongly.